luci-app-usteer: Add parameters specifically for usteer-ng#8419
luci-app-usteer: Add parameters specifically for usteer-ng#8419systemcrash merged 1 commit intoopenwrt:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
818c0d4 to
25c99dd
Compare
|
The angle you're going for here is that the new settings work or are benign. How about detecting which agent is installed via a fs.stat or fs.exec command -v and revealing settings based on that result? It might prevent users lodging bug reports 'this setting doesn't work'.... |
|
I can try to see if fs.stat works |
|
usteer-ng has new default values, probably they should also be reflected here. NilsRo/usteer-ng@b69ac48 Even better is to push for the original project to wake up to life... openwrt/usteer#10 |
b573277 to
e6d58c1
Compare
Ok I added an elegant detection
Its only 1 parameter, also i cannot really detect what the default is. The only thing I could do is check if one of the other parameters are included and then change the default based on that. But to be honest, I dont think it is that important, especially because usteer-ng is not officially supported. @systemcrash what do you think, also switch on that, or just leave it slightly less complex? |
|
Well, you can elide a default for the parameter, and retain whatever value is provided, especially if it's a flag. We can put this in and see how it fares. master only? |
2934a93 to
cf30bda
Compare
|
Ok i added a switch for that one parameter. Im fine either way, this or the previous version. |
usteer-ng is the forked version of usteer with more options and improvements. This commit allows setting the additional options in luci-app-usteer. Next to that a small bug is fixed. Signed-off-by: Ramon Van Gorkom <Ramon00c00@gmail.com>
cf30bda to
7da6435
Compare
|
optimized a bit |
|
Merged. Thanks @Ramon00 |
usteer-ng is the forked version of usteer with more options and improvements.
This commit allows setting the additional options in luci-app-usteer.
Next to that a small bug is fixed.