Avoid integer overflow when swapping the buffer#11
Open
acfloria wants to merge 2 commits intoopenwfm:masterfrom
Open
Avoid integer overflow when swapping the buffer#11acfloria wants to merge 2 commits intoopenwfm:masterfrom
acfloria wants to merge 2 commits intoopenwfm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large geotiffs, larger than 46341x46341 pixels, contain more pixels than int32 can hold (2,147,483,647). This caused an integer overflow when swapping the buffer and a subsequent segfault. It also lead due to the integer overflow the files being wrongly converted.
Tested with a 63072x39780 input file.