This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Add fileName and lineNumber in WeaveLog*#640
Open
didishe90 wants to merge 1 commit intoopenweave:masterfrom
Open
Add fileName and lineNumber in WeaveLog*#640didishe90 wants to merge 1 commit intoopenweave:masterfrom
didishe90 wants to merge 1 commit intoopenweave:masterfrom
Conversation
gerickson
suggested changes
Jan 14, 2021
Contributor
gerickson
left a comment
gerickson
left a comment
There was a problem hiding this comment.
This will need to be conditionalized by a compile-time configuration flag and should be disabled by default. File names, in particular, will lead to an explosion in debug image code size.
Help debug and identify spammy log
didishe90
force-pushed
the
addFileNameAndLine
branch
from
5e5f5c3 to
3675ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Help debug and identify spammy log