This repository was archived by the owner on Dec 20, 2023. It is now read-only.
DeviceLayer: implement CASE auth delegate#566
Open
kghost wants to merge 1 commit intoopenweave:masterfrom
Open
DeviceLayer: implement CASE auth delegate#566kghost wants to merge 1 commit intoopenweave:masterfrom
kghost wants to merge 1 commit intoopenweave:masterfrom
Conversation
Currently, only legacy CASE auth delegate is implemented. The patch implements the new CASE auth delegate interface for device layer. Change-Id: Ifb6a4dcdcd29a75eca47bd84158345bb2253ebff
Contributor
|
I think this needs to be coordinated with @emargolis . He undoubtedly has a commit that makes the same change. |
jaylogue
reviewed
Apr 30, 2020
| virtual WEAVE_ERROR HandleCertValidationResult(bool isInitiator, WEAVE_ERROR& validRes, WeaveCertificateData *peerCert, | ||
| uint64_t peerNodeId, WeaveCertificateSet& certSet, ValidationContext& validContext); | ||
| virtual WEAVE_ERROR EndCertValidation(WeaveCertificateSet& certSet, ValidationContext& validContext); | ||
| #if !WEAVE_CONFIG_LEGACY_CASE_AUTH_DELEGATE |
Contributor
There was a problem hiding this comment.
If we do go with this commit, there's no need to support both legacy and new interfaces. Just force a compile error if WEAVE_CONFIG_LEGACY_CASE_AUTH_DELEGATE is set.
jaylogue
suggested changes
Apr 30, 2020
Contributor
jaylogue
left a comment
jaylogue
left a comment
There was a problem hiding this comment.
Two items to be resolved:
- Coordinate with Evgeni
- Eliminate support for legacy interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only legacy CASE auth delegate is implemented. The patch
implements the new CASE auth delegate interface for device layer.
Change-Id: Ifb6a4dcdcd29a75eca47bd84158345bb2253ebff