WEAV-3246: Dockerfile for weave device manager#249
WEAV-3246: Dockerfile for weave device manager#249NLAVogel wants to merge 1 commit intoopenweave:masterfrom
Conversation
Also add __init__.py so when files are installed in dist-packages they can be imported.
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 54.22% 54.21% -0.02%
==========================================
Files 332 332
Lines 56403 56403
==========================================
- Hits 30586 30579 -7
- Misses 25817 25824 +7
Continue to review full report at Codecov.
|
jaylogue
left a comment
There was a problem hiding this comment.
I'm wondering whether the Weave Device Manager will work correctly in all cases when run inside a Docker instance. In particular, will the Weave rendezvous protocol, which requires IPv6 multicast, work correctly between a Docker instance and a real device?
| RUN cd weave && \ | ||
| ./configure --disable-systemd && \ | ||
| make all && \ | ||
| make install |
There was a problem hiding this comment.
I think we should be using Makefile-Standalone whenever we build any of the desktop tools, rather than invoking ./configure with default args. The former employs project configuration files that configures OpenWeave specifically for desktop use.
Also add init.py so when files are installed in dist-packages they
can be imported.