Skip to content

Conversation

@mbaudin47
Copy link
Collaborator

@mbaudin47 mbaudin47 commented Oct 8, 2025

  • Fixed enumerate list in doc/examples/sensitivity_methods/plot_benchmark_sensitivity_methods.py.
image
  • Added an example into the README, so that the user can known what the package is about.
  • Created an example to show how to create a new reliability benchmark problem.
  • Fixed LaTeX equations of sensitivity problems.
  • Used Black on Python scripts.
  • Updated formula for OpenTURNS 1.26, for reliability problems using ExprTk.

@mbaudin47
Copy link
Collaborator Author

mbaudin47 commented Oct 8, 2025

@mbalesdent. In eeef398, I created a new example to show how to create a new reliability benchmark problem. This was a feature you requested a long time ago. The problem is adapted from #69, i.e. the two-degree-of-freedom damped oscillator. The problem is, however, difficult to solve using plain Monte-Carlo. May you suggest another algorithm which better solves the problem?

@mbaudin47
Copy link
Collaborator Author

mbaudin47 commented Dec 8, 2025

@jschueller : The Github Actions prints:

writing output... [ 60%] auto_examples/sensitivity_problems/plot_gaussian_product_sensitivity .. user_manual/_generated/otbenchmark.GaussianProductSensitivity

(Error in parallel process)
Traceback (most recent call last):

[...]

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 1753: ordinal not in range(128)

This seems to be created by a "ë" in some file, most likely by "Michaël". But I cannot find where. Is there any trick to find the exact location of any Sphinx error?

@jschueller
Copy link
Member

jschueller commented Dec 9, 2025

indeed you have a non-ascii long minus char (−) inside the omega_p - omega_s formula:

$ LC_ALL=C  grep -PInr "[\x80-\xFF]"  otbenchmark/|grep math
otbenchmark/_BoreholeSensitivity.py:29:        * :math:`T_u`: transmissivity of upper aquifer (m²/yr)
otbenchmark/_BoreholeSensitivity.py:31:        * :math:`T_l`: transmissivity of lower aquifer (m²/yr)
otbenchmark/_NLOscillatorSensitivity.py:65:        * :math:`r = (\omega_p − \omega_s) / \omega_a` a tuning parameter.

the m² are ok since they are outside math

you can also see them in colors with

LC_ALL=C  grep --color='auto' -PI -nr "[\x80-\xFF]"  otbenchmark/

@mbaudin47
Copy link
Collaborator Author

Thank you for pointing this. I can now see it indeed using VSCode:

image

@mbaudin47 mbaudin47 requested a review from jschueller December 10, 2025 16:33
@mbaudin47
Copy link
Collaborator Author

@m-balesdent Does this correspond to your requirement?

@mbaudin47
Copy link
Collaborator Author

@regislebrun : Can you review this PR and tell if it corresponds to what you expect?

Closes #113

README.md: Fixed typo. Added an example within the README
Black scripts.
Fixed RP77 for updated SymbolicFunction
Fixed API doc in Sensitivity problems
Fixed API doc in Reliability problems
doc/examples/sensitivity_methods/plot_benchmark_sensitivity_methods.py: Fixed list
doc/examples/reliability_problems/plot_new_reliability_problem.py: Example to create a new reliability problem
examples/scripts/test-computeCDF.py: Comment the testing method
@mbaudin47
Copy link
Collaborator Author

@jschueller : I suggest to review this PR and merge it, if you are ok with that.

@jschueller jschueller merged commit 83496fd into master Jan 5, 2026
2 checks passed
@jschueller jschueller deleted the fixdoc branch January 5, 2026 07:15
@mbaudin47
Copy link
Collaborator Author

@jschueller : Thank you very much and happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants