Skip to content

Add/mmap#19

Open
james-poole-mf wants to merge 6 commits intomainfrom
add/mmap
Open

Add/mmap#19
james-poole-mf wants to merge 6 commits intomainfrom
add/mmap

Conversation

@james-poole-mf
Copy link
Copy Markdown
Contributor

No description provided.

@james-poole-mf james-poole-mf marked this pull request as ready for review November 28, 2023 10:49
Comment on lines +9 to +14
postgresql:
primary:
containerSecurityContext:
enabled: false
podSecurityContext:
enabled: false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add these explicitly into the values.yaml file with defaults set to 'true' so it's easier to see what/where to change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines -1 to -3
# BEGIN COPYRIGHT NOTICE
# (c) Copyright 2023 Micro Focus or one of its affiliates.
# END COPYRIGHT NOTICE
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the copyright notice back in (this is unfortunately a manual step after running make index.yaml)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants