Drop websocket pinning #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
websocket doesn't need to be pinned anymore, python-libjuju is compatible with newer versions now. Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
There are scenarios where the loop was already closed, if that's the case a new one is created and used to run the function.
Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
freyes
force-pushed
the
unpin-websockets
branch
from
3163d2c to
b1deba8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
==========================================
- Coverage 89.50% 89.49% -0.02%
==========================================
Files 42 42
Lines 4718 4730 +12
==========================================
+ Hits 4223 4233 +10
- Misses 495 497 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
gboutry
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websocket doesn't need to be pinned anymore, python-libjuju is compatible with newer versions now.
Ref: juju/python-libjuju#1216