Conversation
bennsimon
requested changes
Feb 14, 2023
Member
bennsimon
left a comment
bennsimon
left a comment
There was a problem hiding this comment.
The configs module changes are not part of this fix.
|
|
||
| @Override | ||
| public void storeAccessToken(final OAuth2AccessToken token, final OAuth2Authentication authentication) { | ||
| final String key = authenticationKeyGenerator.extractKey(authentication); |
Member
There was a problem hiding this comment.
Check for null authentication.
| @Override | ||
| public void storeAccessToken(final OAuth2AccessToken token, final OAuth2Authentication authentication) { | ||
| final String key = authenticationKeyGenerator.extractKey(authentication); | ||
| jdbcTemplate.update("delete from oauth_access_token where authentication_id = ?", key); |
Member
There was a problem hiding this comment.
Log info when jdbcTemplate.update("delete from oauth_access_token where authentication_id = ?", key); eventually finds a duplicate and deletes it.
ekigamba
suggested changes
Feb 15, 2023
| public void storeAccessToken(final OAuth2AccessToken token, final OAuth2Authentication authentication) { | ||
| final String key = authenticationKeyGenerator.extractKey(authentication); | ||
| jdbcTemplate.update("delete from oauth_access_token where authentication_id = ?", key); | ||
| if( key == null || authentication == null) |
Contributor
There was a problem hiding this comment.
- I think the check for authentication needs to happen before passing the
authenticationobject to the function - Evaluate and see if super needs to be called even if we skip the delete operation
Contributor
Author
There was a problem hiding this comment.
super needs to be called since it is mostly operating on the OAuth2AccessToken token.
…rver-web into duplicate-auth-id-fix
update version code
ekigamba
suggested changes
Feb 21, 2023
| @Override | ||
| public void storeAccessToken(final OAuth2AccessToken token, final OAuth2Authentication authentication) { | ||
|
|
||
| if( authentication != null){ |
Contributor
There was a problem hiding this comment.
Nitpick: Formatting here and line 103
…rver-web into duplicate-auth-id-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.