Skip to content

Optimize filter selection condition#332

Open
hamza-vd wants to merge 7 commits intomasterfrom
optimize-filter-selection-condition
Open

Optimize filter selection condition#332
hamza-vd wants to merge 7 commits intomasterfrom
optimize-filter-selection-condition

Conversation

@hamza-vd
Copy link
Copy Markdown
Collaborator

@hamza-vd hamza-vd commented Feb 2, 2023

This PR will

  • Make use of changes introduced in this immunization module's PR
  • Update the queries in RegisterQueryProvider to reference status column in VaccineOverdueCountRepository instead of search virtual table. This will eliminate issue mentioned here
  • Update Migration and count select query in VaccineOverdueCountRepositoryHelper
  • Update query in getFilterSelectionCondition to filter children fromVaccineOverdueCountRepository instead of search table

@hamza-vd hamza-vd requested a review from qiarie February 2, 2023 09:43
@hamza-vd hamza-vd marked this pull request as ready for review February 23, 2023 06:18
@hamza-vd hamza-vd force-pushed the optimize-filter-selection-condition branch from 414010f to 38fb0a1 Compare February 23, 2023 07:34
@hamza-vd hamza-vd force-pushed the optimize-filter-selection-condition branch from 7be4633 to 0048979 Compare May 10, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant