Open
Conversation
ellykits
requested changes
Nov 18, 2021
Contributor
ellykits
left a comment
ellykits
left a comment
There was a problem hiding this comment.
Write Database migration for data in production
Contributor
|
@junaidwarsivd please see this ticket as well related to @ellykits 's feedback |
Contributor
|
@junaidwarsivd also CI seems to be failing due to an OOM error when running the tests. Could you try updating the memory limit here to |
ellykits
requested changes
Nov 22, 2021
| vaccine.setTeam(allSharedPreferences.fetchDefaultTeam(providerId)); | ||
| vaccine.setTeamId(allSharedPreferences.fetchDefaultTeamId(providerId)); | ||
|
|
||
| vaccine.setOutreach(vaccine.getLocationId().equals(allSharedPreferences.fetchDefaultLocalityId(providerId))? 0 : 1); |
Contributor
There was a problem hiding this comment.
Add null check that defaults to 0
Contributor
Author
There was a problem hiding this comment.
@ndegwamartin could you please change -Xmx4096m because i dont have permission to change the Ci.yml file
cc: @ellykits @dubdabasoduba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added outreach column population for the condition if the vaccine locationID is not the main facility locationID then it is set to 1 else 0 in order to detect vaccines given in outreach or in the facility
issue ref # opensrp/opensrp-client-path-zeir#193