Adding the translatable text attribute to several widgets#835
Open
dubdabasoduba wants to merge 47 commits intodevelopfrom
Open
Adding the translatable text attribute to several widgets#835dubdabasoduba wants to merge 47 commits intodevelopfrom
dubdabasoduba wants to merge 47 commits intodevelopfrom
Conversation
Attention Flags issue fix done
PDF naming fix added
Develop subforms issue
…d_translation_strings
dubdabasoduba
commented
Jun 16, 2022
Member
Author
dubdabasoduba
left a comment
dubdabasoduba
left a comment
There was a problem hiding this comment.
@SebaMutuku @junaidwarsivd Please review the comments
| dependencies { | ||
| implementation 'androidx.appcompat:appcompat:1.3.1' | ||
| implementation('org.smartregister:opensrp-client-native-form:2.1.17-SNAPSHOT@aar') { | ||
| implementation('org.smartregister:opensrp-client-native-form:2.1.18-PREVIEW-SNAPSHOT@aar') { |
Member
Author
There was a problem hiding this comment.
Please publish the library from master
| exclude group: 'io.ona.rdt-capture', module: 'lib' | ||
| } | ||
| implementation('org.smartregister:opensrp-client-core:4.3.26-SNAPSHOT@aar') { | ||
| implementation('org.smartregister:opensrp-client-core:5.0.3-PREVIEW-SNAPSHOT@aar') { |
Member
Author
There was a problem hiding this comment.
Please publish the library from master
Comment on lines
+110
to
+114
| if(isPermissionGranted()) | ||
| { | ||
| loadContactSummaryData(); | ||
| } | ||
| else if(!isPermissionGranted() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) |
Member
Author
There was a problem hiding this comment.
What Permission is this?
Comment on lines
+382
to
384
| public void createContactSummaryPdf(String womanName) { | ||
| //overridden | ||
| } |
Member
Author
There was a problem hiding this comment.
Any reason we are not implementing this?
| facts.put(key, value); | ||
| } else { | ||
| facts.put(key, ""); | ||
| facts.put(key, ValueObject); |
| def powerMockVersion = '2.0.7' | ||
| implementation project(":opensrp-anc") | ||
| implementation('org.smartregister:opensrp-client-native-form:2.1.17-SNAPSHOT@aar') { | ||
| implementation('org.smartregister:opensrp-client-native-form:2.1.18-PREVIEW-SNAPSHOT@aar') { |
Member
Author
There was a problem hiding this comment.
Publish the libraries from master
| } | ||
|
|
||
| implementation('org.smartregister:opensrp-client-core:4.3.26-SNAPSHOT@aar') { | ||
| implementation('org.smartregister:opensrp-client-core:5.0.3-PREVIEW-SNAPSHOT@aar') { |
Member
Author
There was a problem hiding this comment.
Publish the libraries from master
Search by alt name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.