Skip to content

Form configurability compatibility update#523

Open
allan-on wants to merge 6 commits intodevelopfrom
521-form-configurability-compatibility-update
Open

Form configurability compatibility update#523
allan-on wants to merge 6 commits intodevelopfrom
521-form-configurability-compatibility-update

Conversation

@allan-on
Copy link
Copy Markdown
Contributor

@allan-on allan-on commented Jun 2, 2020

  • Updated Activities to extend DynamicJsonFormActivity instead of JsonFormActivity
  • Removed native-forms dependencies
  • Added doc-config client-core dependency
  • Updated renamed QueryBuilder methods

See #521 for details

Fix failing RegisterFragmentPresenterTest
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 4, 2020

.scheduleJob(SyncSettingsServiceJob.TAG, TimeUnit.MINUTES.toMillis(BuildConfig.CLIENT_SETTINGS_SYNC_MINUTES),
getFlexValue(BuildConfig.CLIENT_SETTINGS_SYNC_MINUTES));
DocumentConfigurationServiceJob
.scheduleJob(DocumentConfigurationServiceJob.TAG, TimeUnit.MINUTES.toMillis(BuildConfig.CLIENT_SETTINGS_SYNC_MINUTES),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the job to run immediately after login?? I'll see if I can direct you to the exact location

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekigamba In the LoginInteractor#scheduleJobsImmediately() ? 🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allan-allay Yea, I think that's it. Also add it to run when the sync button on the register is clicked

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Let me implement the changes

@keymane
Copy link
Copy Markdown

keymane commented Jun 4, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- reference-app/src/main/java/org/smartregister/anc/job/AncJobCreator.java  1
         

See the complete overview on Codacy

Schedule immediately on login & on sync icon clicked
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 48bdb6b and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@dubdabasoduba dubdabasoduba requested a review from ekigamba July 3, 2020 07:33
@dubdabasoduba dubdabasoduba changed the base branch from master to develop May 20, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants