Skip to content

Upgrade to keycloak v20.0.0#29

Open
t7tran wants to merge 1 commit intoopensingular:mainfrom
t7tran:keycloak-20
Open

Upgrade to keycloak v20.0.0#29
t7tran wants to merge 1 commit intoopensingular:mainfrom
t7tran:keycloak-20

Conversation

@t7tran
Copy link

@t7tran t7tran commented Nov 7, 2022

Some deprecated APIs have been removed in version 20.0.0. This PR should address it.

@mikkeljohnsen
Copy link

Should "dist/singular-user-storage-provider.jar" not be removed from this PR ?

@t7tran
Copy link
Author

t7tran commented Nov 22, 2022

@mikkeljohnsen do you mean the old jar should be retained? I will redo once confirmed.

@mikkeljohnsen
Copy link

Yes, I just tested the patch and it works.

@t7tran
Copy link
Author

t7tran commented Nov 23, 2022

Done. Please review. Thanks.

@Kendak
Copy link

Kendak commented Jan 30, 2023

Hello, is there any chance to approve this PR ?

@KDMRyanT
Copy link

KDMRyanT commented Feb 1, 2023

I have downloaded the code for this pull request - it does get passed the error specified. However in testing further with the provider, I may have discovered a bug/problem. It looks like the provider can look up single users, however on the users screen in a realm - and then attempting to list all users or '*' results in no results found? If I search for individual users, they are found in select queries given, however list all users doesn't appear to work. Testing further - in the docker container output log I see that the 'list all users' is actually running the sql query for selecting a user by username??? To get around this - in the search of users - instead of using the button, I specified '%'. I can then list all the users. Might be something to look into to polish this up. I do still think this pull request should be in place on the larger repository.

@dasosjt
Copy link

dasosjt commented Feb 1, 2023

@KDMRyanT Does this error show up in previous version? Asking because of the change itself is updating the version and changing the way it passes the args.

Maybe this is an error independent from this? I have not checked that out from previous version.

@KDMRyanT
Copy link

KDMRyanT commented Feb 1, 2023

@dasosjt From my usage of keycloak 19.0.3 and singular-keycloak-database-federation ( previous checkout/compile ) this listing of all users was working.

Copy link

@messaoud06 messaoud06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There some changes on the version 20+, it was implemented by this version

@K1ng-F1sher
Copy link

Any chance this PR will be completed soon?
I'm looking to implement user federation in Keycloak 20.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants