Conversation
|
Should "dist/singular-user-storage-provider.jar" not be removed from this PR ? |
|
@mikkeljohnsen do you mean the old jar should be retained? I will redo once confirmed. |
|
Yes, I just tested the patch and it works. |
|
Done. Please review. Thanks. |
|
Hello, is there any chance to approve this PR ? |
|
I have downloaded the code for this pull request - it does get passed the error specified. However in testing further with the provider, I may have discovered a bug/problem. It looks like the provider can look up single users, however on the users screen in a realm - and then attempting to list all users or '*' results in no results found? If I search for individual users, they are found in select queries given, however list all users doesn't appear to work. Testing further - in the docker container output log I see that the 'list all users' is actually running the sql query for selecting a user by username??? To get around this - in the search of users - instead of using the button, I specified '%'. I can then list all the users. Might be something to look into to polish this up. I do still think this pull request should be in place on the larger repository. |
|
@KDMRyanT Does this error show up in previous version? Asking because of the change itself is updating the version and changing the way it passes the args. Maybe this is an error independent from this? I have not checked that out from previous version. |
|
@dasosjt From my usage of keycloak 19.0.3 and singular-keycloak-database-federation ( previous checkout/compile ) this listing of all users was working. |
messaoud06
left a comment
There was a problem hiding this comment.
There some changes on the version 20+, it was implemented by this version
|
Any chance this PR will be completed soon? |
Some deprecated APIs have been removed in version 20.0.0. This PR should address it.