-
Notifications
You must be signed in to change notification settings - Fork 83
OCPBUGS-68220: Update logrus to 1.9.3 to address CVE-2025-65637 #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.17
Are you sure you want to change the base?
Conversation
This updates the github.com/sirupsen/logrus dependency from v1.9.0 to v1.9.3 to fix CVE-2025-65637, a security vulnerability in the logrus logging library. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@davegord: This pull request references Jira Issue OCPBUGS-68220, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davegord The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@davegord: This pull request references Jira Issue OCPBUGS-68220, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@davegord: This pull request references Jira Issue OCPBUGS-68220, which is valid. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@davegord: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Changes
Test plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk dependency update focused on a vendored logging library; main impact is in
logrusWriterLevelscanning behavior, which could slightly change log line splitting/formatting for very large writes.Overview
Updates vendored
github.com/sirupsen/logrusfromv1.9.0tov1.9.3(includinggo.mod/go.sum/vendor/modules.txt) to pick up the CVE fix.The updated
logruswriter.gochanges howEntry.WriterLevelreads from the pipe: it configures the scanner to safely handle large inputs (chunking up tobufio.MaxScanTokenSize) and trims trailing\r\nbefore logging, plus minor README/vendor doc adjustments.Written by Cursor Bugbot for commit c573cef. This will update automatically on new commits. Configure here.