Skip to content

kube-compare: remove golangci-lint#72623

Open
sebrandon1 wants to merge 1 commit intoopenshift:mainfrom
sebrandon1:remove_golangci_lint
Open

kube-compare: remove golangci-lint#72623
sebrandon1 wants to merge 1 commit intoopenshift:mainfrom
sebrandon1:remove_golangci_lint

Conversation

@sebrandon1
Copy link
Member

kube-compare will now be using Github Actions to maintain its linter as per: openshift/kube-compare#246

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign adhil0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sebrandon1 sebrandon1 force-pushed the remove_golangci_lint branch from ecc6049 to df9370a Compare February 4, 2026 23:25
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sebrandon1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kube-compare-main-golint openshift/kube-compare presubmit Ci-operator config changed
pull-ci-openshift-kube-compare-main-images openshift/kube-compare presubmit Ci-operator config changed
pull-ci-openshift-kube-compare-main-markdownlint openshift/kube-compare presubmit Ci-operator config changed
pull-ci-openshift-kube-compare-main-modtidy openshift/kube-compare presubmit Ci-operator config changed
pull-ci-openshift-kube-compare-main-security openshift/kube-compare presubmit Ci-operator config changed
pull-ci-openshift-kube-compare-main-unit openshift/kube-compare presubmit Ci-operator config changed
pull-ci-openshift-kube-compare-main-unit-report-creator openshift/kube-compare presubmit Ci-operator config changed
pull-ci-openshift-kube-compare-main-verify-deps openshift/kube-compare presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config df9370a link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants