OCPBUGS-11652: SNO: Add enableSystemLogQuery to kubelet conf #39282
Conversation
This is needed to allow "oc adm node-logs" to work on OCP 4.14+ clusters where the node log query feature is present upstream and needs to be explicitly enabled.
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-bug
|
@aravindhp: This pull request references Jira Issue OCPBUGS-11652, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[REHEARSALNOTIFIER]
A total of 202 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-origin-release-4.14-e2e-aws-ovn-single-node |
|
@aravindhp: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aravindhp, soltysh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retitle OCPBUGS-11652: SNO: Add enableSystemLogQuery to kubelet conf |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@aravindhp this looks finished :) is there anything else missing besides getting the approval? |
|
The only question is whether the fix for OCPBUGS-13656 will fix SNO also. So we should wait for that fix to go in and check if it works for SNO. Slack thread about this. |
|
/close openshift/machine-config-operator#3735 fixed the issue and was confirmed in openshift/origin#27992 (comment) |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@aravindhp: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@aravindhp: This pull request references Jira Issue OCPBUGS-11652. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
This is needed to allow "oc adm node-logs" to work on OCP 4.14+ clusters where the node log query feature is present upstream and needs to be explicitly enabled.