Rename MCO bootstrap presubmit and set it to always run

[JoelSpeed]

Reverts #22940

Now that the PR to introduce the test is merged, we should make sure we are gathering the output on future PRs.

• Add bootstrap vs day 2 integration tests based on envtest machine-config-operator#2687

CC @kikisdeliveryservice @sinnykumari @yuqi-zhang

[kikisdeliveryservice]

Given that we have 18 checks running on every PR - I'd much rather we get some runs in manually as opposed to having this auto-run on every PR and adding another.

Adding a hold to collect some runs and evaluate the status of the test.

/hold

[kikisdeliveryservice]

link to runs in MCO repo: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-machine-config-operator-master-bootstrap-e2e

[sinnykumari]

I know this is not the right place to bring this, but when I was manually typing to run this test on a PR I realized that test name is not consistent with others in our repo. e2e-bootstrap is more consistent than bootstrap-e2e. If others feel same way, we can rename the test to e2e-bootstrap.

[yuqi-zhang]

Adding a hold to collect some runs and evaluate the status of the test.

I think this particular test should be pretty safe. It is not a e2e test in the sense that it actually has a running fully-formed cluster, so the chances of it being flaky (like platform tests) should be much lower.

If others feel same way, we can rename the test to e2e-bootstrap.

On the same vein, maybe this is better framed as a "bootstrap unit test"?

[JoelSpeed]

I think this particular test should be pretty safe. It is not a e2e test in the sense that it actually has a running fully-formed cluster, so the chances of it being flaky (like platform tests) should be much lower.

Agreed, I don't think there's really a need to not have this run, as it is more of a unit test and should not be flaky.

On the same vein, maybe this is better framed as a "bootstrap unit test"?

This makes a lot of sense

[sinnykumari]

Thanks Joel for updating the test name.
Can you also update subject of this PR to reflect both commit changes? Otherwise, LGTM
Will let other folks take a look as well in case there is any last minute change.

[kikisdeliveryservice]

/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-config-operator/OWNERS [kikisdeliveryservice]
• ci-operator/jobs/openshift/machine-config-operator/OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Updated the following 4 configmaps:

• ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
• ci-operator-4.10-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-machine-config-operator-release-4.10.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.10.yaml
• job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
• job-config-4.10 configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-machine-config-operator-release-4.10-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.10-presubmits.yaml

Details

In response to this:

Reverts #22940

Now that the PR to introduce the test is merged, we should make sure we are gathering the output on future PRs.

• Add bootstrap vs day 2 integration tests based on envtest machine-config-operator#2687

CC @kikisdeliveryservice @sinnykumari @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

Weird somehow my approval added a lgtm? Seems fine it merged, but v weird.

[sinnykumari]

Weird somehow my approval added a lgtm? Seems fine it merged, but v weird.

I have noticed this as well lot of time for release repo.