Skip to content

Conversation

@JoelSpeed
Copy link
Contributor

Following up on #19845 which prioritised the platforms being migrated to CCMs for 4.9, this adds GCP and VSphere as TechPreviewNoUpgrade release informing jobs.

For now I've included this in the 4.9 jobs but depending on when this merges, we may want to move straight to 4.10.

As of 4.10 GCP and VSphere will also have CCMs in TechPreview and as such this is important to ensure we have sufficient testing of the CCMs.

Note for vSphere, the periodics are scheduled staggered currently, by 15 minutes each. 0, 15, 30 and 45 past the hour. To avoid confusion with those, I've staggered these new ones to 2 hours earlier and on the 0th and 30th minute. This should ensure the suite has time to pass before the other periodics start and use the quota

@openshift-ci openshift-ci bot requested review from frobware and petr-muller August 25, 2021 09:47
@JoelSpeed
Copy link
Contributor Author

/assign @deads2k

@JoelSpeed JoelSpeed force-pushed the gcp-vsphere-tpnu branch 3 times, most recently from ac02f08 to 4c1b9b9 Compare August 27, 2021 09:25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added configs for 4.10, can you add these there as well?

  • ci-operator/config/openshift/release/openshift-release-master__ci-4.10.yaml
  • ci-operator/config/openshift/release/openshift-release-master__nightly-4.10.yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do the same in core-services/release-controller/_releases/release-ocp-4.10.json

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2021
@JoelSpeed
Copy link
Contributor Author

@petr-muller I've updated this to just be 4.10, I think for now we are only really concerned for these platforms on 4.10. Will add to 4.9 at a later date if we decide that's necessary

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse-blocking 4c1b9b96acd49df88d7c9ee97cfa4e0a8f90fbbc link /test pj-rehearse-blocking
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-vsphere-techpreview 4c1b9b96acd49df88d7c9ee97cfa4e0a8f90fbbc link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-gcp-techpreview-serial 4c1b9b96acd49df88d7c9ee97cfa4e0a8f90fbbc link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-vsphere-techpreview-serial f3cdb6b link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-vsphere-techpreview f3cdb6b link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.10-e2e-gcp-techpreview f3cdb6b link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.10-e2e-gcp-techpreview-serial f3cdb6b link /test pj-rehearse
ci/prow/pj-rehearse f3cdb6b link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor Author

The tests are failing for two reasons, one is openshift/origin#26449, the other is a lack of a 4.10 nightly. Will try and run the rehearsals again once these two issues are resolved

@petr-muller
Copy link
Member

@JoelSpeed I think it's fine to merge the jobs despite the failures. They will simply start giving signal once these preconditions start to hold

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5d0e2ea into openshift:master Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@JoelSpeed: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__ci-4.10.yaml using file ci-operator/config/openshift/release/openshift-release-master__ci-4.10.yaml
    • key openshift-release-master__nightly-4.10.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.10.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/techpreview/OWNERS
    • key openshift-e2e-gcp-techpreview-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/techpreview/openshift-e2e-gcp-techpreview-workflow.metadata.json
    • key openshift-e2e-gcp-techpreview-workflow.yaml using file ci-operator/step-registry/openshift/e2e/gcp/techpreview/openshift-e2e-gcp-techpreview-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/gcp/techpreview/serial/OWNERS
    • key openshift-e2e-gcp-techpreview-serial-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/gcp/techpreview/serial/openshift-e2e-gcp-techpreview-serial-workflow.metadata.json
    • key openshift-e2e-gcp-techpreview-serial-workflow.yaml using file ci-operator/step-registry/openshift/e2e/gcp/techpreview/serial/openshift-e2e-gcp-techpreview-serial-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/vsphere/techpreview/OWNERS
    • key openshift-e2e-vsphere-techpreview-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/vsphere/techpreview/openshift-e2e-vsphere-techpreview-workflow.metadata.json
    • key openshift-e2e-vsphere-techpreview-workflow.yaml using file ci-operator/step-registry/openshift/e2e/vsphere/techpreview/openshift-e2e-vsphere-techpreview-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/vsphere/techpreview/serial/OWNERS
    • key openshift-e2e-vsphere-techpreview-serial-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/vsphere/techpreview/serial/openshift-e2e-vsphere-techpreview-serial-workflow.metadata.json
    • key openshift-e2e-vsphere-techpreview-serial-workflow.yaml using file ci-operator/step-registry/openshift/e2e/vsphere/techpreview/serial/openshift-e2e-vsphere-techpreview-serial-workflow.yaml
Details

In response to this:

Following up on #19845 which prioritised the platforms being migrated to CCMs for 4.9, this adds GCP and VSphere as TechPreviewNoUpgrade release informing jobs.

For now I've included this in the 4.9 jobs but depending on when this merges, we may want to move straight to 4.10.

As of 4.10 GCP and VSphere will also have CCMs in TechPreview and as such this is important to ensure we have sufficient testing of the CCMs.

Note for vSphere, the periodics are scheduled staggered currently, by 15 minutes each. 0, 15, 30 and 45 past the hour. To avoid confusion with those, I've staggered these new ones to 2 hours earlier and on the 0th and 30th minute. This should ensure the suite has time to pass before the other periodics start and use the quota

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed JoelSpeed deleted the gcp-vsphere-tpnu branch September 7, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants