-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add TechPreviewNoUpgrade Periodics for GCP and VSphere #21338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TechPreviewNoUpgrade Periodics for GCP and VSphere #21338
Conversation
|
/assign @deads2k |
ac02f08 to
4c1b9b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added configs for 4.10, can you add these there as well?
- ci-operator/config/openshift/release/openshift-release-master__ci-4.10.yaml
- ci-operator/config/openshift/release/openshift-release-master__nightly-4.10.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also do the same in core-services/release-controller/_releases/release-ocp-4.10.json
4c1b9b9 to
f3cdb6b
Compare
|
@petr-muller I've updated this to just be 4.10, I think for now we are only really concerned for these platforms on 4.10. Will add to 4.9 at a later date if we decide that's necessary |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The tests are failing for two reasons, one is openshift/origin#26449, the other is a lack of a 4.10 nightly. Will try and run the rehearsals again once these two issues are resolved |
|
@JoelSpeed I think it's fine to merge the jobs despite the failures. They will simply start giving signal once these preconditions start to hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Following up on #19845 which prioritised the platforms being migrated to CCMs for 4.9, this adds GCP and VSphere as TechPreviewNoUpgrade release informing jobs.
For now I've included this in the 4.9 jobs but depending on when this merges, we may want to move straight to 4.10.
As of 4.10 GCP and VSphere will also have CCMs in TechPreview and as such this is important to ensure we have sufficient testing of the CCMs.
Note for vSphere, the periodics are scheduled staggered currently, by 15 minutes each. 0, 15, 30 and 45 past the hour. To avoid confusion with those, I've staggered these new ones to 2 hours earlier and on the 0th and 30th minute. This should ensure the suite has time to pass before the other periodics start and use the quota