OPRUN-4441: fix(ote): Fix SingleOwnNamespace test for Boxcutter runtime compatibility #619
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@camilamacedo86: This pull request references OPRUN-4441 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@camilamacedo86: This pull request references OPRUN-4441 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
camilamacedo86
force-pushed
the
fix-ote-test-to-work-with-both
branch
from
bd669d7 to
6728fcd
Compare
camilamacedo86
changed the title
| // Use a non-existent namespace with valid DNS name. | ||
| // This will pass config validation but fail during resource creation | ||
| // when the controller tries to create Roles/RoleBindings in this namespace. | ||
| nonExistentWatchNamespace := fmt.Sprintf("%s-nonexistent", namespace) |
There was a problem hiding this comment.
/hold we might need to see if Boxcutter should not have Reason=Failed as well
openshift-ci
bot
added
the
do-not-merge/hold
| // Check that installation is NOT successful - this works for both Helm and Boxcutter | ||
| // Helm sets: Installed=False, Reason=Failed | ||
| // Boxcutter might set: Progressing=True, Reason=Retrying OR Installed=False | ||
| // The key is that Installed should NOT be True with Reason=Succeeded |
There was a problem hiding this comment.
I think we should remove any checks on the Installed condition. I think the only thing that would matter is to check that Progressing is False with reason InvalidConfiguration. The Installed condition may still have True if there's an existing successful installation on the cluster. E.g.
- Install extension successfully
- Update the configuration to something that isn't valid
camilamacedo86
force-pushed
the
fix-ote-test-to-work-with-both
branch
from
6728fcd to
bd4ce75
Compare
camilamacedo86
force-pushed
the
fix-ote-test-to-work-with-both
branch
from
bd4ce75 to
66f347d
Compare
|
@camilamacedo86: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Clsoe in favor of : #628 |
3 participants
Ensure that the criteria of the check work for both runtimes so that we can fix the issue: blob:https://prow.ci.openshift.org/84dc591d-cca0-4df2-978c-d555f06b335e
The test was checking Helm-specific condition states (Installed=False,
Reason=Failed) which don't match Boxcutter's reconciliation model.
Changed assertions to be runtime-agnostic by:
Test now validates behaviour across both Helm and Boxcutter runtimes.