-
Notifications
You must be signed in to change notification settings - Fork 29
feat(openshift-ai): add OpenShift AI toolset #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: macayaven The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @macayaven. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adds comprehensive OpenShift AI support following the project's established patterns from core and helm toolsets. Tools organized into 5 categories: - Data Science Projects (4 tools): list, get, create, delete - Models (5 tools): list, get, create, update, delete - Applications (4 tools): list, get, create, delete - Experiments (4 tools): list, get, create, delete - Pipelines (6 tools): pipelines (list, get, create, delete) + pipeline runs (list, get) Implementation details: - Uses simple init*() functions with slices.Concat() pattern - Direct function references for handlers (matches core/helm) - CRD-based cluster detection via DataScienceCluster resources - Client caching in Kubernetes manager for efficiency - Zero vendor changes - Comprehensive snapshot tests for all tool definitions Total: 23 tools for complete OpenShift AI lifecycle management
b1b9c24 to
1d5c5dd
Compare
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
This PR adds comprehensive OpenShift AI / Open Data Hub support to the MCP server, enabling AI assistants to manage data science workloads through 23 new MCP tools across 5 resource categories.
Features
Resource Categories (23 tools total):
Implementation
Follows established patterns from core and helm toolsets:
init*()functions withslices.Concat()pattern (matches core/helm)New packages:
pkg/openshift-ai/: Core client and resource handlerspkg/toolsets/openshift-ai/: MCP tool implementationspkg/api/datascience_project.go: Tool definitions and schemasTesting
All tests pass:
Verified with MCP Inspector and live cluster smoke test.
Design Decisions
Checklist
make buildpassesmake lintpassesmake testpasses