-
Notifications
You must be signed in to change notification settings - Fork 152
OCPBUGS-73848: test/e2e - do not use ambiguous container image short names #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-73848: test/e2e - do not use ambiguous container image short names #343
Conversation
cecc48d to
5b0eea8
Compare
989cda4 to
e0bdfa1
Compare
|
/retest |
|
@ibihim: This pull request references Jira Issue OCPBUGS-73848, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
|
@ibihim: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
everettraven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a super tiny non-blocking nit.
/lgtm
test/e2e/proxy_test.go
Outdated
| require.NoError(t, err) | ||
|
|
||
| backendImage := "nginxdemos/nginx-hello:plain-text" | ||
| backendImage := "registry.k8s.io/e2e-test-images/agnhost:2.53" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the currently used version in openshift/origin is registry.k8s.io/e2e-test-images/agnhost:2.56: https://github.com/openshift/origin/blob/93a5612582f5e22a2ca64e67af649db09b6d9a9f/test/extended/util/image/image.go#L53
Should we match that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
The e2e tests fail on OCP 4.22 because RHEL 9 enforces fully qualified
container image names ("short name mode"). The backend image
`nginxdemos/nginx-hello:plain-text` is rejected with ImageInspectError
since Podman cannot determine which registry to pull from.
Replace it with `registry.k8s.io/e2e-test-images/agnhost:2.53`, a fully
qualified image that is the standard e2e test image across OpenShift
repositories. The agnhost image requires running the `netexec` subcommand
to start its HTTP server.
Update test expectations from "URI: /" to "NOW:" to match agnhost's
response format.
Assisted-By: Claude Code
e0bdfa1 to
3f104b5
Compare
|
@ibihim: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
everettraven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, ibihim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by CI job e2e-component results |
|
@xingxingxia: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ibihim: Jira Issue Verification Checks: Jira Issue OCPBUGS-73848 Jira Issue OCPBUGS-73848 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ibihim: new pull request created: #344 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ibihim: new pull request created: #345 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ibihim: new pull request created: #346 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ibihim: new pull request created: #347 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ibihim: new pull request created: #348 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ibihim: #343 failed to apply on top of branch "release-4.16": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
registry.k8s.io/e2e-test-images/agnhost:2.53netexec --http-port=8080)Problem
The e2e-component tests fail on OCP 4.22/RHEL 9 with:
RHEL 9 requires fully qualified container image names. The unqualified
nginxdemos/nginx-hellois ambiguous since Podman cannot determine which registry to pull from.Solution
Use
registry.k8s.io/e2e-test-images/agnhost:2.53, which is the standard test image adopted across OpenShift repositories (openshift/origin PR #29672). It is fully qualified and mirrored in OpenShift CI infrastructure.The test expectations are updated from
"URI: /"to"NOW:"because agnhost'snetexecreturns timestamps rather than echoing the request path.Test plan
Note
Assisted-By: Claude Code