OCPCLOUD-2010: Re-vendor api and library-go for external platform support

[adriengentil]

Revendor openshift/api and openshift/library-go in order to support the
external platform type when feature set TechPreviewNoUpgrade is
enabled.

library-go PR: openshift/library-go#1496
API PR: openshift/api#1434

[openshift-ci-robot]

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

Details

In response to this:

Revendor openshift/api and openshift/library-go in order to support the
external platform type.

library-go PR: openshift/library-go#1496
API PR: openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[elmiko]

lgtm, just waiting on the upstream PRs so we can revendor

[elmiko]

looks like the template output needs to be adjusted for the change in feature gates perhaps?

[adriengentil]

TestFeatureGateDrift test fails with:

 kubelet_config_features_test.go:45: template FeatureGates do not match openshift/api FeatureGates: (tmpl=[map[AlibabaPlatform:true OpenShiftPodSecurityAdmission:true RetroactiveDefaultStorageClass:false]], api=[&map[AlibabaPlatform:true CloudDualStackNodeIPs:true OpenShiftPodSecurityAdmission:true RetroactiveDefaultStorageClass:false]]

looks like the template output needs to be adjusted for the change in feature gates perhaps?

where is this template? 👀

[adriengentil]

ok I think it's this one https://github.com/openshift/machine-config-operator/blob/master/templates/master/01-master-kubelet/_base/files/kubelet.yaml

[elmiko]

the e2e failures look related to csi driver issues, i don't think it is being caused by this pr.

/lgtm

[adriengentil]

/retest

[adriengentil]

/assign sinnykumari
As @elmiko said, the jobs look to be failing for unrelated reasons (reaching some kind of limits in AWS for the hypershift one)

[openshift-ci-robot]

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

Details

In response to this:

Revendor openshift/api and openshift/library-go in order to support the
external platform type when feature set TechPreviewNoUpgrade is
enabled.

library-go PR: openshift/library-go#1496
API PR: openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adriengentil]

/retest

[adriengentil]

/retest

[jkyros]

Awesome, hypershift passed
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, elmiko, jkyros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jkyros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@adriengentil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	6442768	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.