OLS-2574: Make related_images.json the only location that defines the OLS images

[syedriko]

Description

Make related_images.json the only location that defines the OLS images

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up dependent library

Related Tickets & Documents

• Related Issue #
• Closes # https://issues.redhat.com/browse/OLS-2574

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• Please provide detailed steps to perform tests related to this code change.
• How were the fix/results from this change verified? Please provide relevant screenshots or results.

[openshift-ci-robot]

@syedriko: This pull request references OLS-2574 which is a valid jira issue.

Details

In response to this:

Description

Make related_images.json the only location that defines the OLS images

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up dependent library

Related Tickets & Documents

• Related Issue #
• Closes # https://issues.redhat.com/browse/OLS-2574

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• Please provide detailed steps to perform tests related to this code change.
• How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[syedriko]

/retest

[xrajesh]

@syedriko Are we still using this file ?

[raptorsun]

yes, this is the template to generate bundle container file

[raptorsun]

seems unintended downgrade

[syedriko]

Fixed.

[raptorsun]

https://github.com/openshift/lightspeed-operator/blob/main/Dockerfile#L37
we should copy the related image file into the operator container,too.

[syedriko]

https://github.com/openshift/lightspeed-operator/blob/main/Dockerfile#L37 we should copy the related image file into the operator container,too.

Not sure I see what for. We normally pass the operand images to the operator on the command line at runtime, I'd rather not create another way of doing the same thing.

[openshift-ci]

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.