Skip to content

OCPBUGS-74511: remove RouteExternalCertificate feature gate #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jcmoraisjr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-74511: remove RouteExternalCertificate feature gate #2122

jcmoraisjr wants to merge 1 commit into from

Conversation

@jcmoraisjr
Copy link
Member

@jcmoraisjr jcmoraisjr commented Feb 10, 2026

RouteExternalCertificate featuregate is now enabled by default. This update is removing the opts used to hold its value, hardcoding the behavior when the value is true.

This update needs to be in sync with o/kubernetes and o/openshift-apiserver.

@jcmoraisjr
remove RouteExternalCertificate feature gate
0531c5f 
RouteExternalCertificate is now enabled by default. This update is
removing the opts used to hold its value, hardcoding the behavior when
the value is true.

This update needs to be in sync with o/kubernetes and
o/openshift-apiserver
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 10, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2026

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-74511, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

RouteExternalCertificate featuregate is now enabled by default. This update is removing the opts used to hold its value, hardcoding the behavior when the value is true.

This update needs to be in sync with o/kubernetes and o/openshift-apiserver.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcmoraisjr
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from Miciah and deads2k February 10, 2026 10:49
@jcmoraisjr jcmoraisjr mentioned this pull request Feb 10, 2026
Open
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2026

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@melvinjoseph86 melvinjoseph86 mentioned this pull request Feb 10, 2026
Open
@jcmoraisjr
Copy link
Member Author

jcmoraisjr commented Feb 11, 2026

/hold
needs to be merged after openshift/kubernetes#2585 and openshift/openshift-apiserver#604

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melvinjoseph86 melvinjoseph86 Awaiting requested review from melvinjoseph86

@deads2k deads2k Awaiting requested review from deads2k

@Miciah Miciah Awaiting requested review from Miciah

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcmoraisjr @openshift-ci-robot