NO-JIRA: pkg/operator/certrotation: Remove imprecise logging

[tchap]

Right now secret/configmap annotation change logging is happening within utility functions, which are not always used to really apply changes, but only to generate desired state. This causes log entries mentioning changes applied, which are actually not being applied at all:

2025-11-24T16:53:39.702034264Z I1124 16:53:39.701986       1 annotations.go:52] Updating "openshift.io/owning-component" annotation for openshift-kube-scheduler/serviceaccount-ca, diff:   string(
2025-11-24T16:53:39.702034264Z -        "",
2025-11-24T16:53:39.702034264Z +        "kube-scheduler",
2025-11-24T16:53:39.702034264Z   )
2025-11-24T16:54:39.701953103Z I1124 16:54:39.701910       1 annotations.go:52] Updating "openshift.io/owning-component" annotation for openshift-kube-scheduler/serviceaccount-ca, diff:   string(
2025-11-24T16:54:39.701953103Z -        "",
2025-11-24T16:54:39.701953103Z +        "kube-scheduler",
2025-11-24T16:54:39.701953103Z   )
2025-11-24T16:55:39.703760397Z I1124 16:55:39.703705       1 annotations.go:52] Updating "openshift.io/owning-component" annotation for openshift-kube-scheduler/serviceaccount-ca, diff:   string(
2025-11-24T16:55:39.703760397Z -        "",
2025-11-24T16:55:39.703760397Z +        "kube-scheduler",
2025-11-24T16:55:39.703760397Z   )
2025-11-24T16:56:39.703589851Z I1124 16:56:39.703545       1 annotations.go:52] Updating "openshift.io/owning-component" annotation for openshift-kube-scheduler/serviceaccount-ca, diff:   string(
2025-11-24T16:56:39.703589851Z -        "",
2025-11-24T16:56:39.703589851Z +        "kube-scheduler",
2025-11-24T16:56:39.703589851Z   )

This patch removes the log statements from EnsureTLSMetadataUpdate and indirectly also NewTLSArtifactObjectMeta, moving logging into relevant reconciliation loops, really emitting logs when a change is there.

The current situation actually causes a log entry every minute in every sync in kube-scheduler-operator and others as well I am sure.

[openshift-ci-robot]

@tchap: This pull request explicitly references no jira issue.

Details

In response to this:

Right now secret/configmap annotation change logging is happening within utility functions, which are not always use to really apply changes, but only to generate desired state. This cases log entries mentioning changes applied, which are actually not being applied at all.

This patch removes the log statements from EnsureTLSMetadataUpdate and indirectly also NewTLSArtifactObjectMeta, moving logging into relevant reconciliation loops, really emitting logs when a change is there.

The current situation actually causes a log entry every minute in every sync in kube-scheduler-operator and others as well I am sure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.