Skip to content

manifestclient: reject WatchList #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 8, 2026
Merged

manifestclient: reject WatchList #2073

openshift-merge-bot merged 1 commit into from
Jan 8, 2026

Conversation

@p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Jan 7, 2026 •
edited
Loading

Reject sendInitialEvents=true (WatchList) for manifest client with a clear error. Returning an error forces clients to fallback to a standard LIST request.

Rationale: we read from disk, WatchList is unnecessary, and forcing an error keeps a single "list" path.

This PR will unblock #2055

@openshift-ci openshift-ci bot requested a review from deads2k January 7, 2026 09:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@p0lyn0mial p0lyn0mial force-pushed the manifestclient-watchlist-unsupported branch from 9d69d25 to db95de2 Compare January 7, 2026 12:59
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-roman
Copy link

rh-roman commented Jan 7, 2026

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2026
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Jan 7, 2026

@jacobsee feel free to cancel the hold once you are ok with this pr/approach.

@jacobsee
Copy link
Member

jacobsee commented Jan 8, 2026

/lgtm
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobsee, p0lyn0mial, rh-roman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aca7ba3 into openshift:master Jan 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@bertinatto bertinatto Awaiting requested review from bertinatto

@jacobsee jacobsee Awaiting requested review from jacobsee

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@jacobsee jacobsee

@rh-roman rh-roman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@p0lyn0mial @rh-roman @jacobsee