NO-JIRA: Internalize removed schema1 manifest type into library-go #2068
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ardaguclu: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ardaguclu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ardaguclu
force-pushed
the
schema1
branch
2 times, most recently
from
c86a916 to
eae9544
Compare
ardaguclu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
These PRs are an experimentation how to upgrade distribution/v3 to newer version. I'm closing them for now. |
|
@ardaguclu: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
schema1 has been removed from the v3.0.0 version of distribution/distribution/v3 package. This is one of the reasons that we are not able to upgrade to latest version of distribution/distribution/v3 (more important one is registry client removal). This PR tries to internalize schema1 manifest type into library-go.
This PR is subset of this #1972 by only internalizing schema1. I think, it might be better to open small, targeted PRs to prevent any regressions (and easily revert if that happens).