Fix API resource discovery to properly parse GroupVersion#259
Fix API resource discovery to properly parse GroupVersion#259leo8a wants to merge 2 commits intoopenshift:mainfrom
Conversation
The getSupportedResourceTypes function was attempting to access res.Group and res.Version fields that don't exist on APIResource. The group and version are part of the APIResourceList, not the individual resources. This fix parses the GroupVersion from list.GroupVersion and applies it to all resources in that list, resolving the "missing group/version" warnings for cluster-scoped resources like Config, OperatorGroup, etc. Signed-off-by: Leonardo Ochoa-Aday <lochoa@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @lack |
Update test discovery client to properly group resources by GroupVersion and set the GroupVersion field on each APIResourceList. This matches real Kubernetes API behavior where resources are returned in separate lists per group/version. This fixes the test failures caused by the API resource discovery fix and eliminates duplicate resource counting (27 down to 14 unique resources). Signed-off-by: Leonardo Ochoa-Aday <lochoa@redhat.com>
|
@leo8a: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
The getSupportedResourceTypes function was attempting to access res.Group and res.Version fields that don't exist on APIResource. The group and version are part of the APIResourceList, not the individual resources.
This fix parses the GroupVersion from list.GroupVersion and applies it to all resources in that list, resolving the "missing group/version" warnings for cluster-scoped resources like Config, OperatorGroup, etc.
Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com