-
Notifications
You must be signed in to change notification settings - Fork 27
OCPNODE-4041: Add a reference konflux release doc #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sairameshv The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a567571 to
a11a759
Compare
|
This doc also requires further changes that are to be done to the |
a11a759 to
c5447dc
Compare
|
@sairameshv: This pull request references OCPNODE-4041 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sairameshv: This pull request references OCPNODE-4041 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
KONFLUX_RELEASE.md
Outdated
|
|
||
| The InstaSlice operator uses File-Based Catalog (FBC) releases for different OCP versions. Each new OCP version requires changes in **two separate repositories**: | ||
|
|
||
| ### Part A: konflux-release-data Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like you should either mention that the new applications you want to release have already been created or add steps here on how to do that. For example you need to create the new dynamicacceleratorslicer-fbc-4-20 application and get everything building.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put Part B first and include the steps to create the new application at the end of that, then Part A comes. This is a more logical flow.
| - Access to the konflux-release-data repository | ||
| - Access to the instaslice-fbc repository | ||
|
|
||
| ### Environment Setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it will get stale really quick.
We should just link to this repo and provide good onboarding docs there.
|
I would expect some reference links back to the Konflux docs. They are useful to understand the process, but don't have the best examples. We also have done this work before so they are example PRs in the repos for much of this work. I think more links to the official docs and specific examples would make this doc more maintainable and more useful. |
Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
c5447dc to
0ead51a
Compare
@cpmeadors , Could you help quoting some of the example PRs that you worked for the earlier release on the instaslice-fbc repo and any if required? I would be adding them along with the konflux docs |
|
/override ci/prow/e2e-bundle-4.20-runc |
|
@sairameshv: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
|
/override ci/prow/e2e-bundle-4-19-runc |
|
@sairameshv: Overrode contexts on behalf of sairameshv: ci/prow/e2e-bundle-4-19-runc, ci/prow/e2e-bundle-4-20-runc, ci/prow/e2e-bundle-runc DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sairameshv: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Reference doc for the future releases of DAS operator via Konflux
Generated by Claude
/cc @kannon92 @cpmeadors