OCPBUGS-13628: Revert "remove special cases for featureset in rendering" #7183
Conversation
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
1 similar comment
|
/lgtm |
|
/lgtm This stopped CCO rendering the featuregate status which is required now by other components for their rendering stages |
stbenjam
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@stbenjam: This pull request references Jira Issue OCPBUGS-13628, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ci/prow/e2e-aws-ovn
Something going on with the bootstrap here that's broken before it even gets to this change, no journals from the bootstrap machine present |
|
@JoelSpeed: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I reported the outage to test platform, looks like something with the image registry. |
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn Unrelated failures, overriding to unblock nightlies |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stbenjam: Jira Issue OCPBUGS-13628: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13628 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Reverts #7158, tracked by OCPBUGS-13628
Per OpenShift policy, we are reverting this breaking change to get payloads flowing again.
Since this landed, all installs are failing. See https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.nightly/release/4.14.0-0.nightly-2023-05-12-064129 for example jobs.
It looks like openshift/library-go#1528 plus a revendor in cluster-config-operator is needed for this to work. If possible please try the relevant PR's together perhaps using cluster-bot to prove this change doesn't break.
CC: @deads2k, @patrickdillon