Skip to content

Conversation

@shay23bra
Copy link
Contributor

Update renovate tool to be able to update UBI images

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2026

@shay23bra: This pull request references MGMT-22731 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Update renovate tool to be able to update UBI images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from eranco74 January 28, 2026 11:18
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

Renovate configuration is expanded with a schema reference, multiple managers (custom.regex and tekton), customManager with Dockerfile regex matching, and three packageRules for update grouping and control. Changes shift from basic configuration to structured, multi-manager setup.

Changes

Cohort / File(s) Summary
Renovate configuration schema and manager setup
renovate.json
Adds $schema reference; expands labels from flat array to multi-line nested structure. Enables custom.regex and tekton managers. Introduces customManager with regex-based Dockerfile matcher to extract currentValue and currentDigest, binding to docker datasource. Establishes three packageRules: Konflux build pipeline grouping on Saturday, UBI runtime image labeling for registry.access.redhat.com/ubi9/ubi-minimal, and disabled major update rule for ubi-minimal from docker datasource.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested a review from romfreiman January 28, 2026 11:18
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shay23bra
Once this PR has been reviewed and has the lgtm label, please assign jc-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@renovate.json`:
- Around line 4-7: The Renovate config currently auto-applies the labels "lgtm"
and "approved" via the labels array, which bypasses human review; update the
"labels" setting to remove those auto-approval labels (delete "lgtm" and
"approved") or replace them with non-approval labels and/or add stricter
controls (disable automerge/auto-approve for dependency updates, or scope
auto-approval to a vetted group via a rule) so Renovate PRs no longer get
automatic code-review approval; look for the "labels" array in the renovate.json
and change it accordingly.
- Around line 14-18: The regex in the "tekton" -> managerFilePatterns entry is
malformed (unescaped dot and wrong wildcard) so it doesn't correctly match files
under a .tekton directory; update the pattern string in the managerFilePatterns
array for the "tekton" object to a proper regex that escapes the dot and matches
any files under the .tekton directory (i.e., use an anchored pattern that
escapes "." and includes a ".*" for trailing path), ensuring you edit the
managerFilePatterns value where "tekton" is defined.

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@shay23bra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibio-reinstall 4be9345 link false /test ibio-reinstall
ci/prow/e2e-ibio 4be9345 link true /test e2e-ibio

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants