-
Notifications
You must be signed in to change notification settings - Fork 24
MGMT-22731: Add To Renovate Tool - Update UBI-minimal Version Automatically #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@shay23bra: This pull request references MGMT-22731 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughRenovate configuration is expanded with a schema reference, multiple managers (custom.regex and tekton), customManager with Dockerfile regex matching, and three packageRules for update grouping and control. Changes shift from basic configuration to structured, multi-manager setup. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shay23bra The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@renovate.json`:
- Around line 4-7: The Renovate config currently auto-applies the labels "lgtm"
and "approved" via the labels array, which bypasses human review; update the
"labels" setting to remove those auto-approval labels (delete "lgtm" and
"approved") or replace them with non-approval labels and/or add stricter
controls (disable automerge/auto-approve for dependency updates, or scope
auto-approval to a vetted group via a rule) so Renovate PRs no longer get
automatic code-review approval; look for the "labels" array in the renovate.json
and change it accordingly.
- Around line 14-18: The regex in the "tekton" -> managerFilePatterns entry is
malformed (unescaped dot and wrong wildcard) so it doesn't correctly match files
under a .tekton directory; update the pattern string in the managerFilePatterns
array for the "tekton" object to a proper regex that escapes the dot and matches
any files under the .tekton directory (i.e., use an anchored pattern that
escapes "." and includes a ".*" for trailing path), ensuring you edit the
managerFilePatterns value where "tekton" is defined.
|
@shay23bra: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update renovate tool to be able to update UBI images