-
Notifications
You must be signed in to change notification settings - Fork 441
HPCASE-206:Add TLSAdherence feature gate #7635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
HPCASE-206:Add TLSAdherence feature gate #7635
Conversation
|
@richardsonnick: This pull request references HPCASE-206 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Skipping CI for Draft Pull Request. |
|
@richardsonnick: This pull request references HPCASE-206 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: richardsonnick The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds the TLSAdherence feature gate entry to HyperShift's feature gate configuration files.
This is a sibling PR to openshift/api#2680 which adds a new tlsAdherence field to the APIServer config resource. Since HyperShift embeds configv1.APIServerSpec in the HostedCluster types 1, we need to ensure this new field is properly gated at the TechPreview level to prevent accidental GA exposure.
The feature gate is added as:
Which issue(s) this PR fixes:
Fixes N/A
Related:
openshift/api#2680
openshift/enhancements#1910
Special notes for your reviewer:
Checklist: