Add new --featuregate-manifest to /usr/bin/cluster-config-operator render

[enxebre]

CI is currently borken https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn/1653511338548269056/artifacts/e2e-aws-ovn/run-e2e/artifacts/TestCreateCluster_PreTeardownClusterDump/namespaces/e2e-clusters-glkxm-example-qmb9l/core/pods/logs/kube-apiserver-79b6c48d7-mzv44-init-bootstrap-previous.log.

This introduced a new command which is effectively required openshift/cluster-config-operator#288

This introduced new status in featureGate CRD openshift/api#1405

Here it was added to the installer github.com/openshift/installer/pull/6990

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

I think you may also need --rendered-manifest-files=/tmp/manifests and a --payload-version flag too, does the script have any idea what payload version is being deployed?

[jparrill]

/lgtm

[enxebre]

I think you may also need --rendered-manifest-files=/tmp/manifests and a --payload-version flag too, does the script have any idea what payload version is being deployed?

Right now this is just a shim to get the script happy, the feature gate config for the KAS is actually coming from the HC API and plumbed in here

hypershift/control-plane-operator/controllers/hostedcontrolplane/kas/params.go

Lines 445 to 453 in e7eb32f

	func (p *KubeAPIServerParams) FeatureGates() []string {
	if p.FeatureGate != nil {
	return config.FeatureGates(&p.FeatureGate.FeatureGateSelection)
	} else {
	return config.FeatureGates(&configv1.FeatureGateSelection{
	FeatureSet: configv1.Default,
	})
	}
	}

https://github.com/openshift/hypershift/blob/e7eb32f259b2a01e5bbdddf2fe963b82b331180f/control-plane-operator/controllers/hostedcontrolplane/kas/config.go#LL178C1-L178C1

By looking at the render cluster-config render command I think this should be enough, let's see what it breaks via CI otherwise.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e7eb32f and 2 for PR HEAD b89937b in total

[enxebre]

F0503 11:00:52.315509      10 render.go:53] problem with featuregate manifests: cannot return FeatureGate without rendered manifests
cp: cannot stat '/tmp/output/manifests/*': No such file or directory

updated to include --rendered-manifest-files

[sjenning]

/lgtm

[openshift-ci]

@enxebre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-kubevirt-aws-ovn	21fb8a4	link	false	/test e2e-kubevirt-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.14.0-202305031615.p0.gf662db7.assembly.stream for distgit hypershift.
All builds following this will include this PR.