Handle unsupported platform errors gracefully#14
Conversation
openshift-ci-robot
added
approved
|
Yeah, as a general rule all operators everywhere must gracefully tolerate unrecognized platforms. See https://github.com/openshift/api/blob/master/config/v1/types_infrastructure.go#L34 for a quick description and |
|
This code lgtm, however, should the operator tell user somehow that it's running correctly but did not do anything useful on an unknown platform? "I see the operator running, it does not report any error, so where is my default storage class?" |
openshift-ci-robot
added
size/M
|
@jsafrane added reason field if unsupported platform is detected. PTAL |
|
reason should be camelcase. maybe put it in Message instead? |
gnufied
force-pushed
the
handle-unsupported-platform-errors
branch
from
7c16667 to
d94365d
Compare
|
@wongma7 fixed. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
storage-migration-for-etcd-encryption proposal
8 participants
Unsupported platform isn't really a fatal error. We are just not going to install a storageclass. This fixes deployment on libvirt.