test: Addition of ginkgo framework dependencies and TLS propagation test #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaleemsiddiqu
force-pushed
the
tls-propagation-test
branch
from
48a0740 to
5501ab7
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kaleemsiddiqu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
Local run is successful ... |
Author
|
@ricardomaraschini @ingvagabund @gangwgr please review this. |
gangwgr
reviewed
Feb 11, 2026
cmd/cluster-openshift-controller-manager-operator-tests-ext/main.go
Outdated
Show resolved
Hide resolved
gangwgr
reviewed
Feb 11, 2026
gangwgr
reviewed
Feb 11, 2026
gangwgr
reviewed
Feb 11, 2026
cmd/cluster-openshift-controller-manager-operator-tests-ext/main.go
Outdated
Show resolved
Hide resolved
gangwgr
reviewed
Feb 11, 2026
cmd/cluster-openshift-controller-manager-operator-tests-ext/main.go
Outdated
Show resolved
Hide resolved
gangwgr
reviewed
Feb 11, 2026
cmd/cluster-openshift-controller-manager-operator-tests-ext/main.go
Outdated
Show resolved
Hide resolved
Contributor
|
make 2 commits, vendor changes should be in different commit |
gangwgr
reviewed
Feb 11, 2026
Add vendor dependencies for the Ginkgo testing framework, openshift-tests-extension framework, and testify assertion library Signed-off-by: Kaleemullah Siddiqui <ksiddiqu@redhat.com>
kaleemsiddiqu
force-pushed
the
tls-propagation-test
branch
from
5501ab7 to
8ffbd4c
Compare
Implement end-to-end test to verify that TLS security profile changes propagate from the APIServer to the OpenShift Controller Manager. Signed-off-by: Kaleemullah Siddiqui <ksiddiqu@redhat.com>
kaleemsiddiqu
force-pushed
the
tls-propagation-test
branch
from
8ffbd4c to
dd531db
Compare
gangwgr
reviewed
Feb 11, 2026
| @@ -0,0 +1,8 @@ | |||
| // This file imports test packages to ensure they are included in the build. | |||
Author
There was a problem hiding this comment.
what should be filename here? dependencymagnet.go ?
gangwgr
reviewed
Feb 11, 2026
|
|
||
| // Now verify the TLS config was propagated to the observed config | ||
| t.Log("Verifying TLS config in observed config") | ||
| err = wait.PollUntilContextTimeout(ctx, 5*time.Second, 2*time.Minute, true, func(ctx context.Context) (bool, error) { |
Contributor
There was a problem hiding this comment.
better to create func for verification of tls and move to library-go repo, so it can be use other components
Contributor
There was a problem hiding this comment.
so it can reuse in both restoration and observation for verification
Author
There was a problem hiding this comment.
It is specific to controller-manager operator with couple of checks for TLS 1.3 version only.
I do not know what could be format of a generic TLS config check as this may involve a lot input and combination of checks depending upon the use case for TLS config check.
Contributor
There was a problem hiding this comment.
are you planning similar case in other namespaces? if not then we can keep your change
Contributor
There was a problem hiding this comment.
If you are planning for other namespaces better to keep common func in which we only pass tls values and compare. it will reduce duplicate work for other namespaces
gangwgr
reviewed
Feb 11, 2026
|
|
||
| // Wait for the operator to finish progressing (reconciliation complete) | ||
| // This typically takes 12-15 minutes for TLS changes to propagate | ||
| t.Log("Waiting for operator to complete reconciliation (may take up to 15 minutes)") |
Contributor
There was a problem hiding this comment.
same for this better to create func and move to library-go repo, so it can be use other components
Author
There was a problem hiding this comment.
What is expected here? should i used changes done by you in library-go ? I see that change still in review.
Contributor
There was a problem hiding this comment.
we can use that function here because it will reduce code size
gangwgr
reviewed
Feb 11, 2026
| } | ||
|
|
||
| // Modern profile should have exactly these TLS 1.3 cipher suites | ||
| expectedCiphers := []string{ |
Contributor
There was a problem hiding this comment.
move this in constant out side of case
Author
There was a problem hiding this comment.
I will do the needful after our above discussion resolution.
Contributor
|
@kaleemsiddiqu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for changes done in #407