Skip to content

OCPCLOUD-3347: tls: use centralized TLS profile #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
damdo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OCPCLOUD-3347: tls: use centralized TLS profile #286

damdo wants to merge 3 commits into from

Conversation

@damdo
Copy link
Member

@damdo damdo commented Jan 20, 2026 •
edited
Loading

Start using centralized TLS profile fetched from the APIServer configuration.
Remove kube-rbac-proxy

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026 •
edited by openshift-ci bot
Loading

@damdo: This pull request references OCPCLOUD-3347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026 •
edited by openshift-ci bot
Loading

@damdo: This pull request references OCPCLOUD-3347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Start using centralized TLS profile fetched from the APIServer configuration.
Remove kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from chrischdi and nrb January 20, 2026 14:42
@damdo damdo force-pushed the use-centralized-tls-profile branch from 1739832 to 4011872 Compare January 20, 2026 16:27
@damdo
Copy link
Member Author

damdo commented Jan 20, 2026

Units will be fixed by #287

@damdo damdo force-pushed the use-centralized-tls-profile branch from 4011872 to 9349d48 Compare January 20, 2026 20:35
@damdo
Copy link
Member Author

damdo commented Jan 21, 2026

/retest

@damdo
Copy link
Member Author

damdo commented Jan 22, 2026

/hold

until we sort the main library

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2026
@damdo damdo force-pushed the use-centralized-tls-profile branch from 9349d48 to 056043e Compare February 3, 2026 18:29
@damdo
Copy link
Member Author

damdo commented Feb 4, 2026

/retest

@damdo damdo force-pushed the use-centralized-tls-profile branch 2 times, most recently from df73dbb to bc9c1ce Compare February 4, 2026 21:49
@damdo
Copy link
Member Author

damdo commented Feb 5, 2026

/test e2e-aws-operator

@damdo
Copy link
Member Author

damdo commented Feb 5, 2026

/test e2e-aws-capi-techpreview

@damdo
Copy link
Member Author

damdo commented Feb 5, 2026

/assign @RadekManak

@damdo
Copy link
Member Author

damdo commented Feb 6, 2026

/test e2e-aws-capi-techpreview

@damdo damdo force-pushed the use-centralized-tls-profile branch from bc9c1ce to 1ac409a Compare February 7, 2026 10:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from radekmanak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo damdo force-pushed the use-centralized-tls-profile branch from 1ac409a to a05cbe0 Compare February 8, 2026 10:34
@damdo damdo force-pushed the use-centralized-tls-profile branch from a05cbe0 to b556534 Compare February 8, 2026 16:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2026

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-capi-techpreview b556534 link true /test e2e-aws-capi-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RadekManak
Copy link
Contributor

RadekManak commented Feb 9, 2026

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@nrb nrb Awaiting requested review from nrb

Assignees

@RadekManak RadekManak

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damdo @openshift-ci-robot @RadekManak