-
Notifications
You must be signed in to change notification settings - Fork 141
use new featuregate API #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new featuregate API #730
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all the cluster-config-operator bits have merged. |
|
/retest |
|
Something wrong in CI, logs from KCMO indicate it's not picking up feature gate status Looking at the config operator, seems it is Will retest all, hopefully CI builds have caught up now /retest |
|
preinstall failure /retest |
d2114e9 to
1c5fd5f
Compare
|
/hold cancel now a real bump |
1c5fd5f to
085e612
Compare
|
I'll accept a later revert if need be, but this is the first consumer we need for the CCM migration. |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
needed to be able to unrevert externa azure CCM |
This fixes the issue at runtime, but not at render time. Yet.
proof of openshift/library-go#1468
/hold for real bump