Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 24, 2023

This fixes the issue at runtime, but not at render time. Yet.

proof of openshift/library-go#1468

/hold for real bump

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@openshift-ci openshift-ci bot requested review from ingvagabund and mfojtik April 24, 2023 20:33
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Apr 24, 2023

/test all

the cluster-config-operator bits have merged.

@deads2k
Copy link
Contributor Author

deads2k commented Apr 24, 2023

/retest

@JoelSpeed
Copy link
Contributor

Something wrong in CI, logs from KCMO indicate it's not picking up feature gate status

E0425 00:39:41.965296       1 simple_featuregate_reader.go:303] cluster failed with : missing desired version "4.14.0-0.ci.test-2023-04-24-235643-ci-op-gl07gjib-latest" in featuregates.config.openshift.io/cluster
E0425 00:40:21.492699       1 starter.go:86] timed out waiting for FeatureGate detection
W0425 00:40:21.492727       1 builder.go:106] graceful termination failed, controllers failed with error: timed out waiting for FeatureGate detection

Looking at the config operator, seems it is config-operator version v0.0.0-alpha.0-458-g56d61e7-56d61e71 which does not yet include the changes from the required PR.

Will retest all, hopefully CI builds have caught up now

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2023

preinstall failure

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2023

/hold cancel

now a real bump

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2023
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2023

I'll accept a later revert if need be, but this is the first consumer we need for the CCM migration.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-ccm 085e612 link false /test e2e-aws-ovn-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 25, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2023

needed to be able to unrevert externa azure CCM

@openshift-merge-robot openshift-merge-robot merged commit a4a0712 into openshift:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants