Skip to content

Update library-go dependency #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoelSpeed wants to merge 2 commits into from
Closed

Update library-go dependency #304

JoelSpeed wants to merge 2 commits into from

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented May 15, 2023

Bump to include openshift/library-go#1528 to fix the current feature gate bootstrapping failures.

/hold need to fixup the go.mod once we've proven this works

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
@openshift-ci openshift-ci bot requested review from deads2k and mfojtik May 15, 2023 11:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@deads2k
Copy link
Contributor

deads2k commented May 15, 2023

install-gather in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/304/pull-ci-openshift-cluster-config-operator-master-e2e-aws-ovn/1658077287112773632 doesn't have any journal contents

/retest

@deads2k
Copy link
Contributor

deads2k commented May 15, 2023

/lgtm
/approve
/hold

hold for real bump

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 15, 2023

/retest

1 similar comment
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented May 15, 2023

/retest

@JoelSpeed JoelSpeed force-pushed the bump-library-go-dirs branch from 23652d0 to 13be579 Compare May 15, 2023 17:55
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@deads2k
Copy link
Contributor

deads2k commented May 15, 2023

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps 13be579 link true /test verify-deps
ci/prow/unit 13be579 link true /test unit
ci/prow/images 13be579 link true /test images
ci/prow/e2e-aws-ovn 13be579 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade 13be579 link true /test e2e-upgrade
ci/prow/verify 13be579 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 15, 2023
@deads2k
Copy link
Contributor

deads2k commented May 15, 2023

/hold

something needs updating. unhold and relgtm after.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
@deads2k deads2k mentioned this pull request May 15, 2023
Merged
@deads2k
Copy link
Contributor

deads2k commented May 15, 2023

superceded by #305

/close

@openshift-ci openshift-ci bot closed this May 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

@deads2k: Closed this PR.

Details

In response to this:

superceded by #305

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoelSpeed @deads2k