Skip to content

Conversation

@Danil-Grigorev
Copy link

@Danil-Grigorev Danil-Grigorev commented May 21, 2021

The PR would allow to create Azure static pod to bootstrap node. The pod would look like so:

apiVersion: v1
kind: Pod
metadata:
  name: azure-cloud-controller-manager
  namespace: kube-system
spec:
  priorityClassName: system-node-critical
  hostNetwork: true
  containers:
    - name: cloud-controller-manager
      image: mcr.microsoft.com/oss/kubernetes/azure-cloud-controller-manager:v1.0.0
      imagePullPolicy: IfNotPresent
      command: ["cloud-controller-manager"]
      args:
        - --cloud-provider=azure
        - --controllers=cloud-node # run cloud-node controller only for Node initialization
        - --kubeconfig=/etc/kubernetes/secrets/kubeconfig
        - --cloud-config=/etc/kubernetes/configs/cloud.conf # cloud config is generated by https://github.com/openshift/cluster-cloud-controller-manager-operator/pull/55
        # and copied to /etc/kubernetes/bootstrap-configs by bootkube.sh https://github.com/openshift/installer/pull/4947
        - --leader-elect=false
        - --port=10267
        - -v=2
      livenessProbe:
        httpGet:
          path: /healthz
          port: 10267
        initialDelaySeconds: 20
        periodSeconds: 10
        timeoutSeconds: 5
      volumeMounts:
      - name: secrets
        mountPath: /etc/kubernetes/secrets
      - name: configs
        mountPath: /etc/kubernetes/configs
  volumes:
  - name: secrets
    hostPath:
      path: /etc/kubernetes/bootstrap-secrets
  - name: configs
    hostPath:
      path: /etc/kubernetes/bootstrap-configs

Azure CCM require cloud config flag. The file would be unpacked and delivered to the pod by the implementation in #55

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2021
@openshift-ci openshift-ci bot requested review from elmiko and lobziik May 21, 2021 08:35
@Danil-Grigorev Danil-Grigorev force-pushed the azure-ccm-bootstrap branch 2 times, most recently from 701d763 to a92cd3e Compare June 4, 2021 15:22
@Danil-Grigorev Danil-Grigorev changed the title WIP: Add generation of azure static CCM pod to bootstrap Add generation of azure static CCM pod to bootstrap Jun 8, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2021
@lobziik
Copy link
Contributor

lobziik commented Jun 8, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 8, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

@Danil-Grigorev: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ccm c53379a link /test e2e-aws-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 936dd7d into openshift:master Jun 10, 2021
@Danil-Grigorev Danil-Grigorev deleted the azure-ccm-bootstrap branch June 10, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants