-
Notifications
You must be signed in to change notification settings - Fork 52
Add CRD admission time validation implementation #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add CRD admission time validation implementation #459
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…ompatibilityRequirement
…alidation webhook
This reverts commit 50741b5f64b2e375b9cf24dd88f8f08863e63485.
e2ba702 to
cf9948e
Compare
Based on #458, only the last 4 commits are actually relevant here.
Adds a new webhook that validates changes to CRDs and admits/denies their admission based on the result of the crd checks implemented against them in compatibility requirements