Skip to content

[release-4.17] OCPBUGS-77446: Bump github.com/go-errors/errors to v1.5.1#561

Open
adobes1 wants to merge 2 commits intoopenshift:release-4.17from
adobes1:4.17-fix-vendor
Open

[release-4.17] OCPBUGS-77446: Bump github.com/go-errors/errors to v1.5.1#561
adobes1 wants to merge 2 commits intoopenshift:release-4.17from
adobes1:4.17-fix-vendor

Conversation

@adobes1
Copy link
Copy Markdown

@adobes1 adobes1 commented Feb 27, 2026

github.com/go-errors/errors v1.0.1 includes file cover.out which is ignored by .gitignore causing issues during ART's hermetic builds of ose-cluster-baremetal-operator on Konflux.
github.com/go-errors/errors v1.5.1 does not contain this problematic file.

Same approach as in #492

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@adobes1: This pull request references Jira Issue OCPBUGS-77446, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-58315 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-58315 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents

Requesting review from QA contact:
/cc @jadhaj

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

github.com/go-errors/errors v1.0.1 includes file cover.out which is ignored by .gitignore causing issues during ART's hermetic builds of ose-cluster-baremetal-operator on Konflux.
github.com/go-errors/errors v1.5.1 does not contain this problematic file.

Same approach as in #492

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dtantsur, jadhaj and sadasu February 27, 2026 10:28
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adobes1
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adobes1
Copy link
Copy Markdown
Author

adobes1 commented Mar 4, 2026

/retest

1 similar comment
@adobes1
Copy link
Copy Markdown
Author

adobes1 commented Mar 11, 2026

/retest

@fgallott
Copy link
Copy Markdown

@elfosardo may you have a look at these PRs? (backport till 4.12)
we can fix the failed unit test job if needed

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62d74e02-4f06-4cb2-b06d-5c1ca0ede7b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fgallott
Copy link
Copy Markdown

/test e2e-metal-ipi-bm

1 similar comment
@fgallott
Copy link
Copy Markdown

/test e2e-metal-ipi-bm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 26, 2026

@adobes1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fgallott
Copy link
Copy Markdown

@honza may you have a look at these PRs? (backport till 4.12)
thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants