Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
cc @dtantsur |
|
|
||
| func EnsureAllSecrets(info *ProvisioningInfo) (bool, error) { | ||
| // Create a Secret for the Ironic Password | ||
| // TODO(alegacy): Ironic will do this on its own if we don't create one. Maybe we should retrieve it instead? |
There was a problem hiding this comment.
I assume creating it here, is better than letter IrSO do it.
| } | ||
| imageName := path.Base(fileCompressionSuffix.ReplaceAllString(downloadURL.Path, "")) | ||
|
|
||
| // TODO(alegacy): not sure what needs to happen with the following block |
There was a problem hiding this comment.
not 100% sure how this is used or if it needs to change for IrSO.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alegacy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| spec := ironicv1alpha1.IronicSpec{ | ||
| APICredentialsName: ironicAPICredentialsName, | ||
| TLS: ironicv1alpha1.TLS{ | ||
| CertificateName: tlsSecretName, |
There was a problem hiding this comment.
Set trusted CA when metal3-io/ironic-standalone-operator#420 merges.
|
Open action items:
|
| networking.DHCP = dhcp | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
You'll need to use Overrides to inject OpenShift-specific containers (static IP stuff).
There was a problem hiding this comment.
ok, i'll put that back in. Sorry, got a little too quick on the delete key.
There was a problem hiding this comment.
I've added them back in including the machine-os containers.
Refactor CBO to use the Ironic Standalone Operator (IrSO) for managing the Ironic deployment instead of directly creating and managing the metal3 pod. Key changes: - Add new provisioning/ironic_deployment.go to create and manage Ironic CR - Update controller to manage Ironic CR instead of metal3 deployment - Remove metal3 state service (now handled by IrSO) - Add RBAC permissions for ironic.metal3.io resources - Update deployment state checking to use IrSO-managed deployment - Refactor baremetal_pod.go to work with IrSO-created resources This change delegates Ironic deployment management to IrSO while CBO continues to manage the overall provisioning configuration and BMO. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Allain Legacy <alegacy@redhat.com>
alegacy
force-pushed
the
feature/deploy-ironic-with-irso
branch
from
35c385a to
ef0cb45
Compare
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dtantsur The pending rebase has the prometheus rules. ... is that going to be ported to IrSO along with the service monitor? |
|
@alegacy: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 participants
Refactor CBO to use the Ironic Standalone Operator (IrSO) for managing the Ironic deployment instead of directly creating and managing the metal3 pod.
Key changes:
This change delegates Ironic deployment management to IrSO while CBO continues to manage the overall provisioning configuration and BMO.
🤖 Generated with Claude Code