Skip to content

NO-ISSUE: Update the comment on pull secret generation #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtantsur wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-ISSUE: Update the comment on pull secret generation #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions provisioning/baremetal_secrets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ func createRegistryPullSecret(info *ProvisioningInfo) (bool, error) {
},
Type: corev1.SecretTypeOpaque,
StringData: map[string]string{
// The openshift-machine-api/pull-secret .dockerconfigjson field should be double encoded due to PR
// https://github.com/openshift/cluster-baremetal-operator/pull/184
// ICC expects the pull secret to be additionally base64-encoded since it will be passed to Ignition.
openshiftConfigSecretKey: base64.StdEncoding.EncodeToString(openshiftConfigSecretKeyData),
},
}
Expand Down