OCPCLOUD-3105: Bump cluster-api to v1.11.3#453
OCPCLOUD-3105: Bump cluster-api to v1.11.3#453openshift-merge-bot[bot] merged 8 commits intoopenshift:masterfrom
Conversation
for f in $(find . -iname '*.go' | grep -v vendor); do
sed -i "" 's@sigs.k8s.io/cluster-api/api/v1beta1@sigs.k8s.io/cluster-api/api/core/v1beta1@g' "$f"
sed -i "" 's@sigs.k8s.io/cluster-api/util/conditions/v1beta2@sigs.k8s.io/cluster-api/util/deprecated/v1beta1/conditions/v1beta2@g' "$f"
done
|
|
||
| go 1.24.0 | ||
|
|
||
| replace sigs.k8s.io/cluster-api-provider-azure => github.com/damdo/cluster-api-provider-azure v0.0.0-20251202084521-c2e0e38d1e0e |
There was a problem hiding this comment.
This will need to change once the CAPZ PR merges: openshift/cluster-api-provider-azure#354
damdo
left a comment
There was a problem hiding this comment.
Went through this with @chrischdi
All changes look reasonable to me
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@chrischdi: This pull request references OCPCLOUD-3105 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-gcp-capi-techpreview e2e-vsphere-operator |
1 similar comment
|
/test e2e-gcp-capi-techpreview e2e-vsphere-operator |
|
/retest |
1 similar comment
|
/retest |
|
there is a case failed for gcp, I created a bug https://issues.redhat.com/browse/OCPBUGS-66893 and raised a pr openshift/cluster-api-provider-gcp#254 hope this is correct |
|
/retest /test e2e-aws-capi-techpreview |
|
/retest |
1 similar comment
|
/retest |
|
azure ci fix pr #452 |
|
/retest |
|
/test e2e-azure-capi-techpreview |
|
openshift/cluster-capi-operator#423 May improve the test failures here. |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-gcp-capi-techpreview |
|
/verified by relevant CI jobs passing |
|
@damdo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This test already had been green for this test |
|
@chrischdi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.