OCPSTRAT-1672: Update to use the user specified armEndpoint

[dmc5179]

Update the azure cloud provider operator to always return the first metadata if no name match and metadata is not empty. The reason for this is that the region names of the 2 new Azure-IL6 regions, and the overall cloud name, are not in the list of allowed regions from the openshift installer. Currently a "stub" region name is used like USGovernmentCloud to allow the installer to progress. When this operator queries the armEndpoint it compares the name of the user specified "stub" cloud name, USGovernmentCloud in this case, to the name of the cloud returned by the armEndpoint. In this case they will NOT match which causes an error.

Updating the code such that, if the armEndpoint does return the URI list, use it and continue.

This PR is mostly formatting changes and only this section is new:

+
+   // Always return the first metadata if no name match and metadata is not empty
+   if len(metadata) > 0 {
+       applyMetadataToConfig(metadata[0], endpoint, cloudConfig, env)
+       return nil
+   }
+

[openshift-ci-robot]

@dmc5179: This pull request references OCPSTRAT-1672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Update the azure cloud provider operator to always return the first metadata if no name match and metadata is not empty. The reason for this is that the region names of the 2 new Azure-IL6 regions, and the overall cloud name, are not in the list of allowed regions from the openshift installer. Currently a "stub" region name is used like USGovernmentCloud to allow the installer to progress. When this operator queries the armEndpoint it compares the name of the user specified "stub" cloud name, USGovernmentCloud in this case, to the name of the cloud returned by the armEndpoint. In this case they will NOT match which causes an error.

Updating the code such that, if the armEndpoint does return the URI list, use it and continue.

This PR is mostly formatting changes and only this section is new:

+
+   // Always return the first metadata if no name match and metadata is not empty
+   if len(metadata) > 0 {
+       applyMetadataToConfig(metadata[0], endpoint, cloudConfig, env)
+       return nil
+   }
+

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dmc5179: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azurestack-ipi	769585c	link	true	/test e2e-azurestack-ipi
ci/prow/verify-git-history	769585c	link	false	/test verify-git-history
ci/prow/verify-commits	769585c	link	false	/test verify-commits
ci/prow/e2e-azure-ovn	769585c	link	true	/test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.