Skip to content

Conversation

@mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Oct 30, 2025

Warning

Disclaimer: How boilerplate sets up FIPS compliance should definitely follow Red Hat guidelines. I don't know what they are. I am just making this MR to raise awareness of this configuration and its brief history.

I think this makes FIPS compliance easier than ever - especially the removal of the cgo requirement should allow usage of ubi*-micro images again if there's a desire for that (fewer CVEs to manage!).

@openshift-ci openshift-ci bot requested review from ravitri and typeid October 30, 2025 05:12
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mjlshen
Once this PR has been reviewed and has the lgtm label, please assign joshbranham for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mjlshen mjlshen changed the title POC of replacing boringcrypto with Go's native FIPS-140-3 module Draft: POC of replacing boringcrypto with Go's native FIPS-140-3 module Oct 30, 2025
@mjlshen mjlshen changed the title Draft: POC of replacing boringcrypto with Go's native FIPS-140-3 module WIP: POC of replacing boringcrypto with Go's native FIPS-140-3 module Oct 30, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@mjlshen mjlshen changed the title WIP: POC of replacing boringcrypto with Go's native FIPS-140-3 module POC of replacing boringcrypto with Go's native FIPS-140-3 module Oct 30, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@mjlshen
Copy link
Contributor Author

mjlshen commented Oct 30, 2025

/hold

This shouldn't be merged. It should be worked on internally if important.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
https://go.dev/blog/fips140 boringcrypto is slated to be removed in a
future release.

Signed-off-by: Michael Shen <mishen@umich.edu>
@joshbranham
Copy link
Contributor

This is blocked internally for HCM security to confirm that FIPS-140-3 is good to go. I will follow up with them.

@tonytheleg
Copy link
Contributor

I asked about this a long time ago when the blog first dropped, so it may not be valid information anymore. As I understand it, the FIPS in native Go is still "In process" and is not fully "approved" so there may be some legal/compliance-y back and forth on what that means. +1 to definitely discussing with internal compliance/security teams + the FIPS folks before any major changes. Lately I've been using go-toolset (installed via package manager) for FIPS builds which is essentially Red Hat's fork of Go with all the OpenSSL bits to ensure FIPS compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants