Skip to content

chore: Upgrade Go version from 1.21 to 1.24 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geowa4 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Upgrade Go version from 1.21 to 1.24 #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
508dd9f
remove: Remove servicelogger tool
geowa4 Jan 6, 2026
ac1ef25
chore: upgrade Go version from 1.21 to 1.24
geowa4 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ linters:
- errchkjson
- errname
- errorlint
- execinquery
- exportloopref
- copyloopvar
- ginkgolinter
- gocheckcompilerdirectives
- gochecksumtype
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ OS := $(shell go env GOOS | sed 's/[a-z]/\U&/')
ARCH := $(shell go env GOARCH)

GORELEASER_VERSION="v1.15.0"
GOLANGCI_LINT_VERSION="v1.55.0"
GOLANGCI_LINT_VERSION="v1.62.2"

.PHONY: download-goreleaser
download-goreleaser:
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/openshift/backplane-tools

go 1.21
go 1.24

toolchain go1.22.1
toolchain go1.24.0

require (
cloud.google.com/go/storage v1.36.0
Expand Down
2 changes: 1 addition & 1 deletion pkg/tools/base/mirror.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type Mirror struct {
// LatestVersion retrieves the version info contained within the provided release.txt file
func (t *Mirror) _LatestVersion() (string, error) {
// Retrieve latest release info to determine which version we're operating on
releaseSlug := fmt.Sprintf("%s/release.txt", t.BaseSlug)
releaseSlug := t.BaseSlug + "/release.txt"
releaseData, err := t.Source.GetFileContents(releaseSlug)
if err != nil {
return "", fmt.Errorf("failed to retrieve release info from %s: %w", releaseSlug, err)
Expand Down
104 changes: 0 additions & 104 deletions pkg/tools/servicelogger/servicelogger.go
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions pkg/tools/tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"github.com/openshift/backplane-tools/pkg/tools/osdctl"
"github.com/openshift/backplane-tools/pkg/tools/rosa"
"github.com/openshift/backplane-tools/pkg/tools/self"
"github.com/openshift/backplane-tools/pkg/tools/servicelogger"
"github.com/openshift/backplane-tools/pkg/tools/yq"
"github.com/openshift/backplane-tools/pkg/utils"
)
Expand Down Expand Up @@ -98,9 +97,6 @@ func initMap() {
toolMap[gcloudTool.Name()] = gcloudTool
}

serviceloggerTool := servicelogger.New()
toolMap[serviceloggerTool.Name()] = serviceloggerTool

ocmContainerTool := ocmcontainer.New()
toolMap[ocmContainerTool.Name()] = ocmContainerTool
}
Expand Down