OCPBUGS-64929: Update to diskfs master with ISO 9660 extension fix

[zaneb]

Description

Update to the latest version of go-diskfs, which includes diskfs/go-diskfs#315. This ensures that short filenames (i.e. the ones used for compatibility with consumers that don't support the Rock Ridge extension to ISO9660) are truncated to 8.3 format (i.e. ISO9660 Level 1), in the same way that ISOs created with xorriso in its default mode are. This is required for coreos-installer to be able to find files like e.g. KARGS.JSO (which was previously stored as KARGS.JSON).

How was this code tested?

Generated a minimal ISO using this code and verified that KARGS.JSO and BOOT.CAT have the correct short names.

Assignees

/cc @carbonin

Links

Checklist

• Title and description added to both, commit and PR
• Relevant issues have been associated
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit tests (note that code changes require unit tests)

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@zaneb: This pull request references Jira Issue OCPBUGS-64929, which is invalid:

• expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description

Update to the latest version of go-diskfs, which includes diskfs/go-diskfs#315. This ensures that short filenames (i.e. the ones used for compatibility with consumers that don't support the Rock Ridge extension to ISO9660) are truncated to 8.3 format (i.e. ISO9660 Level 1), in the same way that ISOs created with xorriso in its default mode are. This is required for coreos-installer to be able to find files like e.g. KARGS.JSO (which was previously stored as KARGS.JSON).

How was this code tested?

CI tests

Assignees

/cc @carbonin

Links

Checklist

• Title and description added to both, commit and PR
• Relevant issues have been associated
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit tests (note that code changes require unit tests)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zaneb]

/jira refresh

[openshift-ci-robot]

@zaneb: This pull request references Jira Issue OCPBUGS-64929, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.02%. Comparing base (493c57d) to head (79361b7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   59.02%   59.02%           
=======================================
  Files          27       27           
  Lines        1674     1674           
=======================================
  Hits          988      988           
  Misses        524      524           
  Partials      162      162           

Files with missing lines	Coverage Δ
pkg/isoeditor/isoutil.go	64.38% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [carbonin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test edge-e2e-ai-operator-ztp
/test edge-e2e-metal-assisted-4-20

[carbonin]

/retest

[carbonin]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test edge-e2e-ai-operator-ztp
/test edge-e2e-metal-assisted-4-21

[carbonin]

I'm not sure what's going on with the pending checks here, but hopefully this just merges 🤷

[carbonin]

/override ci/prow/e2e-ai-operator-ztp ci/prow/e2e-metal-assisted ci/prow/edge-e2e-metal-assisted-4-20

[openshift-ci]

@carbonin: Overrode contexts on behalf of carbonin: ci/prow/e2e-ai-operator-ztp, ci/prow/e2e-metal-assisted, ci/prow/edge-e2e-metal-assisted-4-20

Details

In response to this:

/override ci/prow/e2e-ai-operator-ztp ci/prow/e2e-metal-assisted ci/prow/edge-e2e-metal-assisted-4-20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@zaneb: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@zaneb: Jira Issue OCPBUGS-64929: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

• openshift/assisted-image-service#618 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-64929 has not been moved to the MODIFIED state.

Details

In response to this:

Description

Update to the latest version of go-diskfs, which includes diskfs/go-diskfs#315. This ensures that short filenames (i.e. the ones used for compatibility with consumers that don't support the Rock Ridge extension to ISO9660) are truncated to 8.3 format (i.e. ISO9660 Level 1), in the same way that ISOs created with xorriso in its default mode are. This is required for coreos-installer to be able to find files like e.g. KARGS.JSO (which was previously stored as KARGS.JSON).

How was this code tested?

Generated a minimal ISO using this code and verified that KARGS.JSO and BOOT.CAT have the correct short names.

Assignees

/cc @carbonin

Links

Checklist

• Title and description added to both, commit and PR
• Relevant issues have been associated
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit tests (note that code changes require unit tests)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.