-
Notifications
You must be signed in to change notification settings - Fork 57
mockgen deprecated: use uber-go/mock instead #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
=======================================
Coverage 59.02% 59.02%
=======================================
Files 27 27
Lines 1674 1674
=======================================
Hits 988 988
Misses 524 524
Partials 162 162 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, sebrandon1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling tests matching the |
668b520 to
4eaa8dd
Compare
|
New changes are detected. LGTM label has been removed. |
1a3e53f to
09c2927
Compare
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://github.com/golang/mock is marked as archived as of
June 27, 2023. They recommend using go.uber.org/mock.This PR attempts to change the dependency to one that is maintained.
Note: I had to stick to v0.1.0 of the repo because they have moved to a newer version of Golang in later versions. Once Go gets updated this dependency can also bump up the mock version.
Tracking issue: redhat-best-practices-for-k8s/telco-bot#45